Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action should fail if build script fails #24

Closed
tpluscode opened this issue Nov 8, 2021 · 2 comments 路 Fixed by #25
Closed

Action should fail if build script fails #24

tpluscode opened this issue Nov 8, 2021 · 2 comments 路 Fixed by #25

Comments

@tpluscode
Copy link
Collaborator

It came a surprise to me that while node 17 broke some of my builds (re #23), the GH workflows did not actually fail.
So now I have half-deployed websites 馃槵

Not sure if it's something about my code, but if not, I'd expect a failed build to actually break the workflow

@tpluscode
Copy link
Collaborator Author

Here's one example: https://github.com/hypermedia-app/shaperone/runs/4140456096?check_suite_focus=true#step:9:209

It fails and then proceeds with Netlify push

@jsmrcaga
Copy link
Owner

jsmrcaga commented Nov 8, 2021

Hey @tpluscode ! thanks a lot for your issue, you're absolutely right.
I'm not an expert on bash scripts, but I'm guessing we are missing this (a set -e at the start):
https://stackoverflow.com/a/19622300/1895443

it would break fail the script if an error occurs. I'll make a PR this evening (in 2/3 hours)

tpluscode added a commit to tpluscode/action-netlify-deploy that referenced this issue Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants