New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]: Unexpected argument: deploy #12
Comments
Hi @imnotteixeira ! Thanks for opening the issue! I can look into this this evenig (CEST time, so in about 10/11 hours), I hope we're not slowing your development too much. In the meantime try going back one version. I'm taggin @tpluscode to see if you have more time (or sooner) to look into this. |
Yes, it definitely is the problem. Such a stupid mistake, sorry. |
Hey, that didn't break my workflow, it's still in implementation phase :P Anyway, I think I'll manage to use netlify's auto deploys configuration, so I won't need to use this action, nevertheless, I think I've done my part in finding the bug ahaah I can confirm that 1.1.0 worked (not with those features, of course, since they were introduced later) |
@tpluscode no worries! My bad, i reviewed too hastly! Thanks for the bug discovery @imnotteixeira |
Hey, before anything, congratulations on this package, it is really helpful!
My use case is deploying a folder to netlify. Before, I was using v1.1.0 and
NETLIFY_DEPLOY_TO_PROD = true
, but now I want to have deploy previews, which I assume would be done withNETLIFY_DEPLOY_TO_PROD=false
. So I upgraded to v1.3.0 and added some params such as the deploy_alias, but I am getting an error like shown in the picture below.This is my workflow, for reference. The step before deploying is building the resources, hence no build command needed.
Might this be some bug introduced in the latest version? I'd appreciate some help, thanks in advance!
The text was updated successfully, but these errors were encountered: