-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing well-known globals #3582
Conversation
BigInt for ES 11 Intl for node specify, xspecify for mocha
URLSearchParams for browser and node
Thanks! |
setImmediate : true, // v0.9.1+ | ||
clearImmediate : true, // v0.9.1+ | ||
URL : true, // v6.13.0+ | ||
URLSearchParams: true // v6.13.0+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that it matters too much, but URLSearchParams was introduced in v10.0.0+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn, I really checked the history section of URLSearchParams. I saw it was introduced in v6.13.0, but didn't notice that it became a global variable only in v10.0.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11: {
BigInt : false
} it does not work, |
Hello,
I have no idea why this hasn't been noticed before, but some well-known globals are missing from
vars.js
. Here's what I've added:This change is really easy to merge and I'm looking forward to seeing it in the next release.