Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static import versioning #339

Closed
dmail opened this issue Jan 13, 2023 · 2 comments · Fixed by #341
Closed

Static import versioning #339

dmail opened this issue Jan 13, 2023 · 2 comments · Fixed by #341

Comments

@dmail
Copy link
Member

dmail commented Jan 13, 2023

During build

  • when import map are supported
    • do not version static import
    • generate an import map for the versionned url
  • when import map are not supported
    • force systems format to avoid versioning if static imports

While doing this:

  • ensure systems is inlined in html
  • add a param to keep the current behaviour (versioning the static import when import map are not supported)
@dmail
Copy link
Member Author

dmail commented Jan 14, 2023

This is well described in vitejs/vite#6773

@dmail
Copy link
Member Author

dmail commented Jan 18, 2023

Be sure to check for workers where importmap are not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant