Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially vulnerable dependency marked-0.8.2.js #1863

Closed
bhadana-rajesh opened this issue Oct 7, 2020 · 2 comments
Closed

Potentially vulnerable dependency marked-0.8.2.js #1863

bhadana-rajesh opened this issue Oct 7, 2020 · 2 comments

Comments

@bhadana-rajesh
Copy link

Potentially vulnerable dependency marked-0.8.2.js

Please see markedjs/marked@bd4f8c4

marked before 1.1.1 is vulnerable to Regular Expression Denial of Service (REDoS). rules.js have multiple unused capture groups which can lead to a Denial of Service

jsdoc - marked dependency should be upgraded to 1.1.1 or above version.

@dargmuesli
Copy link

marked seems to not be used by default anymore: #1243

For JSDoc 3.6.0, we'll add markdown-it and use it by default, but marked will still be available. For JSDoc 3.7.0, marked will be removed.

So you might be able to mute your vulnerability notifications for that.

@pardoman
Copy link

pardoman commented Nov 24, 2020

Removal of markdown has been proposed back in 2017, see #1413, so I'm not counting on this work landing any time soon.

I was wondering if a simpler approach would be to upgrade the existing marked library version into 1.1.1, given that marked version 1.0.0 is "non-breaking for most users".

I tried looking into making this fix, but gave up after running into the good ol' node-gyp errors, which I'm currently not willing to work through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants