Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for @nx/devkit v19.0.0 #814

Open
bjornharvold opened this issue May 7, 2024 · 5 comments
Open

Add support for @nx/devkit v19.0.0 #814

bjornharvold opened this issue May 7, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@bjornharvold
Copy link

Came with the last major release of Nx today

@ak274
Copy link

ak274 commented May 7, 2024

v5 already works with nx v18..
It should be support for v19?

@edbzn edbzn added the enhancement New feature or request label May 7, 2024
@edbzn
Copy link
Member

edbzn commented May 7, 2024

Hey, will work on it soonish, I think there's no major breaking change.

@edbzn edbzn changed the title Add support for @nx/devkit v18.0.0 Add support for @nx/devkit v19.0.0 May 7, 2024
@bjornharvold
Copy link
Author

👋🏻 @edbzn have an ETA for us? 🫶🏼

@smitev
Copy link

smitev commented Jun 10, 2024

what is the status of the work for upgrading to @nx v19?

@dianjuar
Copy link
Contributor

dianjuar commented Jun 11, 2024

A workaround for this problem is forcing @jscutlery/semver to use Nx V19. This is not ideal; it could lead to unpredictable results if Nx19 contains a breaking change.

For npm

"overrides": {
    "@jscutlery/semver": {
      "@nx/devkit": "YOUR.CURRENT.VERSION"
    }
  }

If you are not using npm as a package manager, you would need to search, which is the equivalent of overrides


This seems safe to use. No major breaking changes are introduced in V19; I did it on ngx-deploy-npm, and everything seems to be working as expected.


UPDATE: I launched a new version with this hack, and everything ran as expected ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants