Fixed issue when "autofix" doesn't fix all files. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could somebody review this PR ? |
| overrides.maxErrors = Infinity; | ||
| } | ||
|
|
||
| checker.getConfiguration().override(overrides); |
There was a problem hiding this comment.
Why not just config.maxErrors = Infinity; above and drop this?
There was a problem hiding this comment.
In case of just validation (not fixing), consumer could configure maximum count of errors.
There was a problem hiding this comment.
But that's already handled by the above if statement. It will only override when opts.fix.
|
I think this is something that should be eventually fixed in core JSCS, though. @blobor Would you mind opening an issue over there? |
|
@sindresorhus, JSCS team already have similar issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't setted "maxErrors" property in your config file, it JSCS uses defaults (50). So in case we run task with "fix" setted to "true" we could only fix 50 errors.
I fixed this problem by setting "Infinity" value in case of fix is setted to true.