Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to JSCS 3.0 #112

Merged
merged 1 commit into from Jun 24, 2016
Merged

Update to JSCS 3.0 #112

merged 1 commit into from Jun 24, 2016

Conversation

acburdine
Copy link
Contributor

@acburdine acburdine commented Jun 12, 2016 •
edited

closes #109

  • update jscs to 3.0
  • fix reporter file name and test issue

@acburdine
deps: jscs@3.0.4
95948ae 
closes jscs-dev#109
- update jscs to 3.0
- fix reporter file name and test issue
@acburdine
Copy link
Contributor Author

@sindresorhus any chance on getting this merged soon? I need this for several of my projects 😄

@sindresorhus
Copy link
Contributor

@mikesherov Anything breaking changes in v3 that this plugin might be affected by?

@acburdine
Copy link
Contributor Author

@sindresorhus I know there are some that would affect various projects using gulp-jscs (a couple of rules were dropped and cause errors if they are included in the .jscsrc). However, I don't think any affect this plugin itself.

@acburdine
Copy link
Contributor Author

acburdine commented Jun 23, 2016 •
edited

FWIW, I tested this with several of my projects and it worked fine

@sindresorhus sindresorhus merged commit 7face69 into jscs-dev:master Jun 24, 2016
@sindresorhus
Copy link
Contributor

Alright

@acburdine acburdine deleted the jscs-3 branch June 24, 2016 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to JSCS 3.0
2 participants
@acburdine @sindresorhus