Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django Admin static files with wrong URL (None value in URL) google-storage backend #1369

Open
AndreLobato opened this issue Mar 20, 2024 · 6 comments

Comments

@AndreLobato
Copy link

I notice this only for the static files for the Django Admin site. All other static files and media URLs seems fine as they return the right URL.

After running ./manage.py collectstatic (success) then ./manage runserver...

Go to Admin site and all the Static files URLs will be as such:

https://storage.googleapis.com/None/admin/css/base.css?X-Goog-Algorithm=...

returning 400.

while the expected would be: https://storage.googleapis.com/{bucket_name}[/{location}]/admin/css/base.css?X-Goog-Algorithm=...

I have only tried with signed URLs as well.

Versions:

Django==5.0.1
django-storages==1.14.2
google-api-core==2.15.0
@varus17
Copy link

varus17 commented Apr 4, 2024

Facing the same issue with Django 4.2.
Migrated from the older STATICFILES_STORAGE to the updated STORAGES, and the bucket_name option does not seem to be passed to the storage backend.

@tonydattolo
Copy link

looks like duplicate issue, same issue with AWS on bucket_name param #1361 (comment)

@jschneier
Copy link
Owner

jschneier commented Apr 30, 2024

It sounds like there is maybe an upstream behavior change. Can people confirm they have django.contrib.staticfiles in INSTALLED_APPS?

https://github.com/django/django/blob/85c154da2f07485a1cdc4d886eee4c1a1ef56137/django/templatetags/static.py#L126-L129

@AndreLobato
Copy link
Author

I confirm I do have django.contrib.staticfiles in INSTALLED_APPS

@jschneier
Copy link
Owner

Can you share a bit more details? I strongly suspect you are hitting the comment on this bug that was fixed. In short, are you on 4.2.5+ and also do you have another package that hasn't transitioned to the new STORAGES setting?

https://code.djangoproject.com/ticket/34773#comment:3

@AndreLobato
Copy link
Author

Ok, thanks for the pointers. I will have another go at this issue and will fill with more details, it's very possible I am using another lib which has not transitioned to new settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants