New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3Boto3Storage().url("my_url.css") return path without ":" after url's protocol #1183

Open

1ronmat opened this issue Oct 4, 2022 · 1 comment

1ronmat commented Oct 4, 2022

S3Boto3Storage().url("css/fils.css") -> "https//cloudfront/static/css/file.css" instead of "https://cloudfront/static/css/file.css".

https://github.com/jschneier/django-storages/blob/master/storages/backends/s3boto3.py#L576

if self.custom_domain:
            url = '{}//{}/{}{}'.format(       #   <------- ':' is missing ?
                self.url_protocol,
                self.custom_domain,
                filepath_to_uri(name),
                '?{}'.format(urlencode(params)) if params else '',
            )

Is it normal ?

The text was updated successfully, but these errors were encountered:

merwok commented Feb 2, 2023

Yes, because the value must en with :, see https://github.com/jschneier/django-storages/blob/master/storages/backends/s3boto3.py#L329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment