test_sftp.SFTPStorageTest test_accessed_time & test_modified_time assume EST timezone

[risicle]

Hi,

It seems as though these tests assume a timezone of UTC-5, resulting in e.g.:

======================================================================
FAIL: test_accessed_time (tests.test_sftp.SFTPStorageTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/nix/store/6v602p5l3c05iiq7jx8y0rjwiv2n8hhj-python3-3.9.13/lib/python3.9/unittest/mock.py", line 1336, in patched
    return func(*newargs, **newkeywargs)
  File "/build/django-storages-1.12.3/tests/test_sftp.py", line 121, in test_accessed_time
    self.assertEqual(self.storage.accessed_time('foo'),
AssertionError: datetime.datetime(2016, 7, 28, 2, 58, 4) != datetime.datetime(2016, 7, 27, 21, 58, 4)

======================================================================
FAIL: test_modified_time (tests.test_sftp.SFTPStorageTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/nix/store/6v602p5l3c05iiq7jx8y0rjwiv2n8hhj-python3-3.9.13/lib/python3.9/unittest/mock.py", line 1336, in patched
    return func(*newargs, **newkeywargs)
  File "/build/django-storages-1.12.3/tests/test_sftp.py", line 128, in test_modified_time
    self.assertEqual(self.storage.modified_time('foo'),
AssertionError: datetime.datetime(2016, 7, 28, 2, 58, 4) != datetime.datetime(2016, 7, 27, 21, 58, 4)

----------------------------------------------------------------------

when it isn't.

[jschneier]

Please open a PR to fix.

…

On Aug 6, 2022, at 17:16, Robert Scott ***@***.***> wrote: Hi, It seems as though these tests assume a timezone of UTC-5, resulting in e.g.: ====================================================================== FAIL: test_accessed_time (tests.test_sftp.SFTPStorageTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/nix/store/6v602p5l3c05iiq7jx8y0rjwiv2n8hhj-python3-3.9.13/lib/python3.9/unittest/mock.py", line 1336, in patched return func(*newargs, **newkeywargs) File "/build/django-storages-1.12.3/tests/test_sftp.py", line 121, in test_accessed_time self.assertEqual(self.storage.accessed_time('foo'), AssertionError: datetime.datetime(2016, 7, 28, 2, 58, 4) != datetime.datetime(2016, 7, 27, 21, 58, 4) ====================================================================== FAIL: test_modified_time (tests.test_sftp.SFTPStorageTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/nix/store/6v602p5l3c05iiq7jx8y0rjwiv2n8hhj-python3-3.9.13/lib/python3.9/unittest/mock.py", line 1336, in patched return func(*newargs, **newkeywargs) File "/build/django-storages-1.12.3/tests/test_sftp.py", line 128, in test_modified_time self.assertEqual(self.storage.modified_time('foo'), AssertionError: datetime.datetime(2016, 7, 28, 2, 58, 4) != datetime.datetime(2016, 7, 27, 21, 58, 4) ---------------------------------------------------------------------- when it isn't. — Reply to this email directly, view it on GitHub <#1171>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAREDWAZH6KTOUAAOZHFWUDVX3I27ANCNFSM55ZK2C7A>. You are receiving this because you are subscribed to this thread.