Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OffsetTime.toEpochSecond() in typings but not implemented #576

Open
StrayAlien opened this issue Dec 28, 2021 · 2 comments
Open

OffsetTime.toEpochSecond() in typings but not implemented #576

StrayAlien opened this issue Dec 28, 2021 · 2 comments
Labels

Comments

@StrayAlien
Copy link
Contributor

Hi all,

The core typings js-joda.d.ts has the above but there seems to be no impl for for in OffsetTime code.

@pithu
Copy link
Member

pithu commented Dec 29, 2021

good catch, should be removed from typings

@pithu pithu added the bug label Dec 29, 2021
@StrayAlien
Copy link
Contributor Author

StrayAlien commented Dec 29, 2021

okay - I figure not doing the reverse and adding the impl is an API / licensing conformity thing? Scuse the naive question - not really across the project history.

If so, would adding typings for WeekFields / ComputedDayOfField in locale be the same? I see they are implemented, just missing typings. I can get a PR in for those.

EDIT: Though is looks like neither WeekFields / ComputedDayOfField is exported from js-joda-locale.js. If you're happy for me to, I'll get a PR in exporting those and adding typings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants