Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wishlist: offer options for smaller data bundles #67

Closed
mlc opened this issue Apr 15, 2019 · 2 comments · Fixed by #73
Closed

wishlist: offer options for smaller data bundles #67

mlc opened this issue Apr 15, 2019 · 2 comments · Fixed by #73

Comments

@mlc
Copy link

mlc commented Apr 15, 2019

Because of moment/moment-timezone#697, the timezone data upon which js-joda-timezone relies has grown massively in size recently, and therefore so has js-joda-timezone itself.

version dist/js-joda-timezone.min.js gzip -9
2.0.1 186973 bytes 25331 bytes
2.0.2 931347 bytes 36084 bytes

moment-timezone is now offering builds of the package with some of the data removed if it is not relevant for timestamps within ±5 years or so of the present. It would be good if js-joda-timzeone could copy this and offer smaller builds of the package for use cases where this makes sense.

@pithu
Copy link
Member

pithu commented Apr 16, 2019

Because we are using the tz data files from moment-timezone it shouldn't be so difficult to use the minimized versions. We are open for PR.

@jkillian
Copy link
Contributor

Hey @mlc I ran in to the same issue as you, so I put up a PR, #73, to offer some alternative builds! Feel free to give it a look and comment if you ahve any thoughts

@pithu pithu closed this as completed in #73 Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants