Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow newer versions of rubyzip #490

Closed
ioanatia opened this issue Mar 24, 2021 · 4 comments · Fixed by #491
Closed

Allow newer versions of rubyzip #490

ioanatia opened this issue Mar 24, 2021 · 4 comments · Fixed by #491

Comments

@ioanatia
Copy link
Contributor

Because of rubyzip/rubyzip#384 when rubyzip is one of the bundled gems, some anti-virus solutions will flag the package as a security issue.

The issue was fixed in rubyzip 2.0.0, however because warbler requires rubyzip with ['~> 1.0', '< 1.4'], upgrading rubyzip to a newer version is not an option AFAICS.

rubyzip is used in ZipSupport which looks like it should still work with the latest version of the gem.

In this case just relaxing the requirement in warbler.gemspec to allow for newer versions of rubyzip might suffice.
@olleolleolle
Copy link
Member

This was the commit which introduced the limitation: #362

@olleolleolle
Copy link
Member

olleolleolle commented Mar 24, 2021 •
edited

Let's make an attempt! @ioanatia Would you like to offer a PR?

@ioanatia
Copy link
Contributor Author

Sure, I can do that.

@headius
Copy link
Member

headius commented Mar 24, 2021

Go for it! Thank you for reporting and attempting a PR!

@ioanatia ioanatia mentioned this issue Mar 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Relax version requirement for rubyzip ioanatia/warbler
3 participants
@olleolleolle @headius @ioanatia