New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON.pretty_generate generates different output to MRI for at least an empty hash #6338
Comments
I see in the other issue that it may be a behavior of json-pure, but in JRuby it ought to be loading the extension. Could be a behavioral change that was done to the C ext and never to the pure-Ruby or Java exts. |
Could you re-file this with the json repo? We do not maintain that source here. |
Do you know how can I tell what version of JSON has really been loaded? I don't see this error in the Java source, so not sure how I'm loading the pure version, if that's what is happening. |
Sorry cancel - I was confused and the bug was in Java as well and I've fixed it in flori/json#449. |
@chrisseaton Thanks for the patch! I can't review it or do anything to move it forward unfortunately, but once it's released we can update JRuby. |
Actually, I can review... will do so now. Someone else will have to merge and release, though. |
That's merged now. I'll close on anticipation you'll pick up the new version soon enough. |
This has not been addressed yet since the change in flori/json#449 has not been released. We do not ship prerelease sources for default gems. @chrisseaton In the future please don't close issues in our tracker unless they are actually resolved and targeted against a specific release. This one flew under the radar for 9.2.14 because it was closed without a release. |
Marked for 9.3 since this is trivial and the fix has not yet been released. Could target 9.2.15 if the fix is released and we do that version before a 9.3 release. |
Updated json for both 9.2 and 9.3 so this should be resolved now. |
The text was updated successfully, but these errors were encountered: