Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(t)weet doesn't work in Docker container #1

Closed
amorriscode opened this issue Apr 26, 2022 · 3 comments · Fixed by #4
Closed

(t)weet doesn't work in Docker container #1

amorriscode opened this issue Apr 26, 2022 · 3 comments · Fixed by #4
Assignees
Labels
bug Something isn't working

Comments

@amorriscode
Copy link

Description

After running a typing test and pressing t, nothing happens.

To Reproduce

  1. Run in Docker (docker run -it coloradocolby/thokr)
  2. Complete a typing test
  3. Press t

Expected behavior

I would expect some sort of Twitter-friendly text to copy paste or Twitter opens up with the tweet pre-filled.

Environment

  • OS: macOS
  • Terminal Emulator: xterm
  • Crate version: 0.1.0
@amorriscode amorriscode added the bug Something isn't working label Apr 26, 2022
@jrnxf
Copy link
Owner

jrnxf commented Apr 26, 2022

@amorriscode I saw this as well when testing in Docker. The reason is docker isn't aware of what your BROWSERS environment variable is. If you passed that in it might work, but I wouldn't be surprised if it didn't given you're not actually taking the test on your host. 🤔 I'm not a huge fan of the copy/paste idea, especially in comparison to the convenience of how it nicely it works outside of docker. Maybe what I'll do is just hide the tweet option if I can rule out that a browser is unavailable.

@amorriscode
Copy link
Author

That's fair. Worlde does the clipboard so I'd say that's a pretty safe/expected approach if available. I'd bet most people don't run it in Docker anyways but who knows!

@jrnxf
Copy link
Owner

jrnxf commented Apr 26, 2022

tracking amodm/webbrowser-rs#46

@jrnxf jrnxf self-assigned this Apr 27, 2022
@jrnxf jrnxf linked a pull request Apr 27, 2022 that will close this issue
4 tasks
@jrnxf jrnxf closed this as completed in #4 Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants