Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[packagers] Readme of homebrew tap points to wrong repository owner #1089

Closed
2 of 4 tasks
aalmiray opened this issue Dec 7, 2022 · 1 comment
Closed
2 of 4 tasks

[packagers] Readme of homebrew tap points to wrong repository owner #1089

aalmiray opened this issue Dec 7, 2022 · 1 comment
Assignees
@aalmiray
Labels
bug Something isn't working released Issue has been released
Milestone
v1.4.0

Comments

@aalmiray
Copy link
Member

aalmiray commented Dec 7, 2022

Task List

  • Steps to reproduce provided
  • Stacktrace (if present) provided
  • Example that reproduces the problem (link to git repository is ideal)
  • Full description of the issue provided (see below)

Steps to Reproduce

  1. Configure a brew packager.
  2. Configure a different owner for the tap repository than the one used for the release
  3. Execute jreleaser prepare
  4. Inspect the generated README.md file

Expected Behaviour

The name of the tap repository owner matches the configured tap owner and not the release owner.

Actual Behaviour

Both release owner and tap owner are the same.

FWIW the name of the tap in the readme may also be wrong. The default is homebrew-tap but one can change the name to homebrew-tools for example. The readme uses "tap" everywhere but it should match the configured value

Environment Information

  • Operating System: N/A
  • JReleaser Version: 1.3.1
  • JDK Version: N/A
@aalmiray aalmiray added the bug Something isn't working label Dec 7, 2022
@aalmiray aalmiray added this to the v1.4.0 milestone Dec 7, 2022
@aalmiray aalmiray self-assigned this Dec 7, 2022
aalmiray added a commit to jreleaser/jreleaser.github.io that referenced this issue Dec 7, 2022
@aalmiray
Document jreleaser/jreleaser#1089
19051b4
aalmiray added a commit to jreleaser/jreleaser.github.io that referenced this issue Dec 13, 2022
@aalmiray
Document jreleaser/jreleaser#1089
8336122
@aalmiray
Copy link
Member Author

Released in v1.4.0 -> https://github.com/jreleaser/jreleaser/releases/tag/v1.4.0

@aalmiray aalmiray added the released Issue has been released label Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aalmiray aalmiray

Labels
bug Something isn't working released Issue has been released
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
1 participant
@aalmiray