Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are some inconsistencies with the current (and old) ThemeRoller #2211

Open
ltdeta opened this issue Feb 5, 2024 · 1 comment
Open

Comments

@ltdeta
Copy link

ltdeta commented Feb 5, 2024

Modify url not working correctly with background textures
If you configure a theme and select a different type for the textures, e.g. "highlight_soft", the theme is created correctly.
However, if you then use the URL from one of the CSS files, all textures are set to "flat" again

"bgTexture[Type]" are loaded allways with the default value "flat"

example custom theme
Theme-Custom-Url-With-bg.txt


Quality of iconsets not identical
The iconsets (2024) are not identical to the ThemeRoller version jQuery 11.4. Some icons are much blurrier
I have attached the icon sets of both versions
jquery-ui-1.12.1-iconsets.zip
jquery-ui-1.11.4-iconsets.zip

jQuery UI 11.4
grafik

jQuery UI 12.x / 13.x
the differences can be seen very clearly in lines 1,2, 7 and 8
ui121

@ltdeta ltdeta changed the title ThemeRoller: modify url not working correctly with background textures There are some inconsistencies with the current (and old) ThemeRoller Feb 8, 2024
@mgol
Copy link
Member

mgol commented Feb 14, 2024

Thanks for the report. Since the issue is already in 1.12, given limited team resources it's not likely to be fixed by the UI team; see the project status at https://blog.jqueryui.com/2021/10/jquery-maintainers-update-and-transition-jquery-ui-as-part-of-overall-modernization-efforts/. PRs are welcome if they're not too complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants