Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number validation methods_nl.js #580

Closed
jvd-nl opened this issue Jan 9, 2013 · 3 comments
Closed

Number validation methods_nl.js #580

jvd-nl opened this issue Jan 9, 2013 · 3 comments

Comments

@jvd-nl
Copy link

jvd-nl commented Jan 9, 2013

The number validation method from methods_de.js can be copied to methods_nl.js, as Holland and Germany have the same decimal and thousands separators (1.000,00).

@jzaefferer
Copy link
Collaborator

I wonder how we can avoid making a straight copy. Rename to methods_nl-de.js and add whatever other locales might match? I don't like either approach.

@jvd-nl
Copy link
Author

jvd-nl commented Jan 9, 2013

Agree with that. When you merge the files, you'll face the fact that dates are separated with dashes in Dutch, instead of dots in German. In that case you should create a file per method, like method.number.de-nl.js. Horrible, isn't it? So I'll prefer the copying 'solution' for now.

@jzaefferer
Copy link
Collaborator

Good point about the dashes, didn't consider the date method. One more reason to do this properly, as outlined in #581. Closing this ticket in favor of the Globalize catch-all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants