Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet jQuery version dependency incorrect #2465

Open
austindorsey opened this issue Apr 26, 2023 · 3 comments
Open

NuGet jQuery version dependency incorrect #2465

austindorsey opened this issue Apr 26, 2023 · 3 comments

Comments

@austindorsey
Copy link

austindorsey commented Apr 26, 2023

Your environment

  • Version of jquery-validate: v1.19.5
  • Browser name and version: Chrome 112.0.5615.138

Current behavior

The jQuery version dependency that NuGet has is >= 1.4.4 instead of >= 1.7.2 which is listed in bower.json.
https://www.nuget.org/packages/jquery.validation#dependencies-body-tab

Error caused:
Uncaught TypeError: $(...).on is not a function

Expected behavior

jQuery version dependency in NuGet should be at least >= 1.7 as $(...).on was added in jQuery 1.7 - https://api.jquery.com/on/

Live demo

https://jsbin.com/wofivuheze/edit?html,console,output

@bytestream
Copy link
Member

I'm not sure what can be done here. https://github.com/jquery-validation/jquery-validation/blob/master/bower.json is correct. Presumably one of the people listed as owners needs to manually correct it.

@RobJohnston
Copy link
Contributor

RobJohnston commented May 4, 2023

I concur, and I'd add that it's odd to use NuGet for a JavaScript library. The better tool in that case is https://github.com/aspnet/LibraryManager.

@austindorsey
Copy link
Author

Yeah, I hear you. It's a legacy application and NuGet is what it was using. I was just updating dependencies and everything broke because it didn't update jQuery as well, so thought I would mention it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants