Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated jQuery functions #2335

Merged
merged 1 commit into from Jun 24, 2020

Conversation

bytestream
Copy link
Member

Description

Replaces functions deprecated in jQuery 3 as per https://api.jquery.com/category/deprecated/

@bytestream bytestream changed the title jQuery deprecations Replaced deprecated jQuery functions Jun 23, 2020
Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - thank you

@staabm staabm requested a review from Arkni June 23, 2020 20:02
Copy link
Member

@Arkni Arkni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me. I left a comment about the isArray method that I would like to discuss

src/core.js Outdated Show resolved Hide resolved
Replaced $.isArray and $.isFunction
Copy link
Member

@Arkni Arkni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants