Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #2188

Closed
gimler opened this issue Jul 5, 2018 · 14 comments
Closed

New release #2188

gimler opened this issue Jul 5, 2018 · 14 comments
Assignees

Comments

@gimler
Copy link

gimler commented Jul 5, 2018

Can you please make a new release. Because the last one is 1 year old.

@staabm
Copy link
Member

staabm commented Jul 5, 2018

@Arkni do you see any known issues which need to be solved before we create a new release?

@staabm staabm self-assigned this Jul 5, 2018
@Arkni
Copy link
Member

Arkni commented Jul 20, 2018

Hi @gimler & @staabm

Sorry for taking so long to respond to this. It was a crazy month for me.

Yes, I do have some issues in my todo list that I would like to see fixed before the next release.
These issues are:

I would also like to merge some (or all if possible) of these pull requests:

I hope to fix these in the next two or three weeks (depends on my schedules).

Thanks for the reminder.

@staabm
Copy link
Member

staabm commented Jul 21, 2018

Thank you arkni for working on these issues.

Take your time and give me a ping in case we are ready to go, or change the things we need to incluse before the next release.

Thanks again

@Arkni
Copy link
Member

Arkni commented Sep 2, 2018

Hi @staabm,

Sorry for taking so long to work on this. I'm a little depressed the last few days and I can't work on the remaining issues and PR. Until I or someone else could, could you please release the current master branch? the remaining issues and PR can be then included in another release.

Thanks a lot :) And sorry for the delay!

@staabm
Copy link
Member

staabm commented Sep 2, 2018

@Arkni dont stress yourself with this project.

You already do an amazing job. We release what we have and in case we need more we can do another release whenever we have something at hand.

Thanks again, I will create a release after beeing home from vacation

@reloxx13
Copy link

reloxx13 commented Sep 5, 2018

so one more year without updates, gg

  • create new release with list of your known issues
  • fix issues
  • create new release
    -profit

there will always be some bugs, if this goes on we will never see an update...
while(bugs==true)
bugs = function doFIx(){return true};
doRelease();

im using composer for your repo and have no access to install/use npm/grunt, and i dont want packages hardcodes/builded from local in the git.

so yep, 1 year old zip release with bugs which got already fixed months ago.
and be sure, if the project is done, i wont touch this repo again.

hope you understand my point of view.

edit: also, the list of open issues you want to fix does not sound like hard breaking things for me.

edit2: or just create a beta/rc release ...

@nj
Copy link

nj commented Sep 7, 2018

@staabm Do you know who have upload to Microsoft Ajax Content Delivery Network?

Would be great if the upcoming release, that the localization files actually matches the expected content, hence the dist versions with the UMD wrapper used in the npm release.

The currently version (1.17.0) breaks integrity, like the case for i.e. messages_da.js.

Older versions doesn't seems to have this issue regarding the language files 😉

@staabm
Copy link
Member

staabm commented Sep 9, 2018

@Arkni could you generate a changelog?

@Arkni
Copy link
Member

Arkni commented Sep 9, 2018

@staabm https://gist.github.com/Arkni/32610a72640145fb09e08b2ff250de5c (minor release)

@staabm
Copy link
Member

staabm commented Sep 9, 2018

thanks @Arkni . great job!

tagged new 1.18.0 release https://github.com/jquery-validation/jquery-validation/releases/tag/1.18.0

its already uploaded on npm and will be published within the next hours/days on the CDNs (should happen automatically on jsdelivery and cdnjs).
MS ajax-cdn was notified manually and they should upload the release in the coming few days.

@reloxx13 feel free to spent your free time on this project like we - the maintainers do. we do this whole project besides our regular jobs for 0 money.

@staabm staabm closed this as completed Sep 9, 2018
@staabm
Copy link
Member

staabm commented Sep 9, 2018

@Arkni could the integrity problem mentioned in #2188 (comment) be our own fault?

@nj
Copy link

nj commented Sep 9, 2018

@staabm The issue is basically that the umdStart, umdMiddle and umdEnd parts were missing - like the file uploaded to CDN was the one in src (without UMD), rather than the one in dist (with UMD).

It's properly fixed already in relation to #2057 included in 1.18.0, which will include all needed files now - avoiding any additional manual action.

Could basically have been the manual process by MS mentioned in your comment, where someone at MS had picked the wrong set of files, when it's not automated.

I'll confirm when CDN is updated 😉

@Arkni
Copy link
Member

Arkni commented Sep 9, 2018

@staabm

We were part of it. Up to 1.17.0, we didn't publish the localization files (minified files included) to GitHub. So, it's the person, thanks for their help, who uploaded the files to MS CDN that used the wrong files (as @nj said).

I hope it will be fixed with the current release (now that we have all the files in the release zip).

Also, thanks for the release :)

@nj
Copy link

nj commented Oct 16, 2018

Seems like Microsoft hasn't updated the CDN yet, though it has been more than a month by now 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants