JQUERY Validation Plugin bug -- rule of min(value) does not respect the minimum value, if the value contains commas

[rchakravarti]

Reference: http://docs.jquery.com/Plugins/Validation/Methods/min#value
Validation Plugin Version 1.8.1
jQuery Core Version 1.5.1

To reproduce the bug:
On the Demo for the Validate a minimum of 13,

1. Enter the value 1,300 (1300 with a comma) with
   the "min" rule in place, validation fails

Any number with a comma fails validation when the
"min" rule is in place, the validate plugin incorrectly reports an error

2. Remove the "min" requirement from the rule, and enter
   1,300 (with the comma) -- the error goes away

Expected behavior:
The plugin should treat numbers with commas in the same
manner as numbers without commas.

---

The same issue was encountered using the "range" rule

Appreciate any reply to help on this issue

[jzaefferer]

A proper solution would use Globalize (https://github.com/jquery/globalize) to handle the number parsing. Requiring that as a dependency isn't really an option, so we need to find a way to support it when you need it.

[ghost]

I submit a solution (in French) :
http://www.mb-blog.fr/2011/09/30/validation-dun-champ-decimal-avec-virgule-ou-point-sous-jquery/

This post was inspired by this article : http://rebuildall.umbraworks.net/2011/03/02/jQuery_validate_and_the_comma_decimal_separator

I think that is a proper solution pending that this issue is fixed.

[rchakravarti]

Mr. Arxuis --

Thank you very much for the reply to my query. We did as you suggested and it seems to work.

However, I would like to point out a small syntax issue with your code :

$.validator.methods.range = function (value, element, param) { return this.optional(element) || (safeStringToFloat(value) >= param[0] && globalizedValue }

There is a close parenthesis missing here -- the corrected line should be :

$.validator.methods.range = function (value, element, param) { return this.optional(element) || (safeStringToFloat(value) >= param[0] && globalizedValue); }

---

Once again, thanks for your input and help in this matter.
With regards,
RC

[ghost]

Hi,

Endeed, I didn't seen that there was many errors in the script (my personal copy was good, though) I hava just submit the good version of the script.

Enjoy ;)

[mlynch]

I recently submitted a PR For this issue with is the same as #379.

I agree with @jzaefferer, my solution doesn't seem that great now thinking about a better, internationalized number parsing function.

[jzaefferer]

I changed my mind on making Globalize a dependency, see #581. Individual work arounds don't scale.

[isatbox]

Hi all, i know its been a year ago this issue raised, but i manged with this trick:

first you initiate the amount field with thousand seperator and decimal seperator.
$('#form_amount_field').autoNumeric('init', {aSep: ' ', aDec: ','});

the you override the minimum validator method:

jQuery.validator.addMethod("min", function(value, element) {
var cents = parseFloat(value.replace(" ", "").replace(",", ".")).toFixed(2) * 100;
return this.optional(element) || (cents >= minimumLimit);
}, jQuery.validator.format("Can not enter amount lower than 5€"));

hope it helps :)

[Spongman]

this is a joke. both issues #188 and #379 which have been unfixed for years are closed referring to each other as reasons for closing. yet this fix STILL has not made it into release.

[joeRinehart]

In case anyone hits this and needs a quick, U.S.-but-customizable fix, I already had numeral.js involved and using it to preformat values was a pinch:

https://gist.github.com/joeRinehart/0e8af523fdfc567cc670ddca2eaff137