Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag and Drop example code has issues when dropping to / from all-day events #2601

Closed
5 tasks done
ganning127 opened this issue May 12, 2024 · 1 comment · Fixed by #2602 · May be fixed by OneUptime/oneuptime#1460
Closed
5 tasks done

Drag and Drop example code has issues when dropping to / from all-day events #2601

ganning127 opened this issue May 12, 2024 · 1 comment · Fixed by #2602 · May be fixed by OneUptime/oneuptime#1460
Labels
bug released

Comments

@ganning127
Copy link
Contributor

Check that this is really a bug

  • I confirm

Reproduction link

Screen.Recording.2024-05-12.at.11.11.22.PM.mov

Bug description

In the Drag and Drop example, there are two bugs:

  1. When dragging an event from the weekly calendar portion TO make it an all day event, it does not work (and just goes back to where it was before the drag)
  2. When dragging an event from the all day portion TO the weekly calendar portion (to not make it an all day event), it does not work (and just goes back to the all day portion)

Expected Behavior

  1. Dragging an event from the weekly calendar portion to the all day portion, the event should become an all day event
  2. Dragging an event fro the all day portion to the weekly calendar portion, the event should no longer be an all day event.

Actual Behavior

See above for actual behavior.

react-big-calendar version

1.12.1

React version

11.11.4

Platform/Target and Browser Versions

macOS Chrome Sonoma 14.4.1

Validations

  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a react-big-calendar issue and not an implementation issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@ganning127 ganning127 added the bug label May 12, 2024
@ganning127 ganning127 mentioned this issue May 12, 2024
Merged
cutterbl pushed a commit that referenced this issue May 14, 2024
@ganning127
fix: bug with dnd drag drop (#2602)
799a72a 
Added an if statement to account for the second case, and changed the updated state value to use the correct allDay value (Thanks to ganning127)

closes #2601
github-actions bot pushed a commit that referenced this issue May 14, 2024
@semantic-release-bot
chore(release): set package.json to 1.12.2 [skip ci]
621b8f1 
## [1.12.2](v1.12.1...v1.12.2) (2024-05-14)

### Bug Fixes

* bug with dnd drag drop ([#2602](#2602)) ([799a72a](799a72a)), closes [#2601](#2601)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@simlarsen simlarsen mentioned this issue Jun 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
1 participant
@ganning127