Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luxon localizer should use LLL to format month instead of MMM #2599

Closed
5 tasks done
rinick opened this issue May 11, 2024 · 2 comments
Closed
5 tasks done

Luxon localizer should use LLL to format month instead of MMM #2599

rinick opened this issue May 11, 2024 · 2 comments
Labels

Comments

@rinick
Copy link

rinick commented May 11, 2024

Check that this is really a bug

  • I confirm

Reproduction link

https://codesandbox.io/p/sandbox/friendly-margulis-n7mfrv?file=%2Fsrc%2Findex.js

Bug description

Luxon localizer use MMM to format month, this might work fine with language like English, but it doesn't work with all the languages, like Chinese
the correct way is to use LLL

Expected Behavior

No response

Actual Behavior

No response

react-big-calendar version

1.12.1

React version

18.2

Platform/Target and Browser Versions

any browser

Validations

  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a react-big-calendar issue and not an implementation issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@cutterbl
Copy link
Collaborator

Correct, which is why we have the various formats props. Please see the documentation for how you may override.

@rinick
Copy link
Author

rinick commented May 14, 2024

hmm, even there is a workaround, it doesn't mean the default behavior should not be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants