Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Month View: events not rendering for the last day of the week. #2531

Open
4 of 5 tasks
davidfaulks opened this issue Mar 11, 2024 · 5 comments
Open
4 of 5 tasks

Month View: events not rendering for the last day of the week. #2531

davidfaulks opened this issue Mar 11, 2024 · 5 comments
Labels

Comments

@davidfaulks
Copy link

Check that this is really a bug

  • I confirm

Reproduction link

n/a

Bug description

In monthly view, multi-day events are not rendering for the last day of the week. Unfortunately, my attempts to make a 'toy example' do not show the error. Changing localization does not affect the issue.
Screenshot 2024-03-10 at 9 12 45 AM

Expected Behavior

Multi-day events should render for the last day of the week.

Actual Behavior

No response

react-big-calendar version

1.11.1

React version

18.2.0

Platform/Target and Browser Versions

macOS Safari 17.31

Validations

  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a react-big-calendar issue and not an implementation issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@davidfaulks
Copy link
Author

I have now confirmed that this happens if the timezone is GMT or larger (eastern hemisphere). I am using the moment localizer, which I know is considered old fashioned nowadays. I will switch to a different date library and report the effects (later).

@davidfaulks
Copy link
Author

Changing to the luxon localizer has no effect, the bug still occurs.

@davidmh
Copy link

davidmh commented Mar 15, 2024

I think I ran into an instance of the same issue here: #2537 (comment)

So maybe we should update getDateForSlot to turn the one-based slots into zero-based indexes

That seems to be a separate issue.

@davidmh
Copy link

davidmh commented Mar 15, 2024

And while rendering the events, I've come up with a temporary solution by adding one second to the end of the range, just to push it over the edge.

Screenshot 2024-03-15 at 08 42 29

@davidfaulks
Copy link
Author

After some more checking, I'll have amend this to 'any timezone with a greater offset than local time'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants