Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(vers): upgrade prop-types #1651

Open
Malvolio opened this issue May 7, 2020 · 2 comments
Open

chore(vers): upgrade prop-types #1651

Malvolio opened this issue May 7, 2020 · 2 comments

Comments

@Malvolio
Copy link
Contributor

Malvolio commented May 7, 2020 •
edited

Do you want to request a feature or report a bug?

A bug

What's the current behavior?

The package.json currently specifies version 15.6.2 of prop-types.

The file propTypes.js refers to the function PropTypes.elementType, which was added in version 15.7.0 of prop-types. (See here.) This causes some type-checking to wrongly throw an NPE in development.

What's the expected behavior?

No NPE.

package.json should be updated to refer to version 15.7.2 of prop-types
@TrySound
Copy link
Collaborator

TrySound commented May 7, 2020

PR welcome!

@Malvolio Malvolio mentioned this issue May 7, 2020
Merged
@Malvolio
Copy link
Contributor Author

Malvolio commented May 7, 2020

Ball is in your court, Bogdon!
image

RistoZoric pushed a commit to RistoZoric/react-big-calendar that referenced this issue Oct 6, 2022
@Malvolio
Update prop-types
9f6da89 
In response to [Issue 1651](jquense/react-big-calendar#1651) in the original repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Malvolio @TrySound