Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to manifest #37

Closed
wants to merge 1 commit into from
Closed

Add tests to manifest #37

wants to merge 1 commit into from

Conversation

avylove
Copy link
Contributor

@avylove avylove commented Jun 2, 2020

I need tests to build the RPM. Looks like they got dropped from the dist tarball when the tests directory was moved.

@jquast jquast closed this Jun 2, 2020
@jquast
Copy link
Owner

jquast commented Jun 2, 2020

This only adds tests for sdist, not for bdist?

$ python setup.py sdist bdist_wheel
running sdist
running egg_info
writing wcwidth.egg-info/PKG-INFO
writing dependency_links to wcwidth.egg-info/dependency_links.txt
writing requirements to wcwidth.egg-info/requires.txt
writing top-level names to wcwidth.egg-info/top_level.txt
reading manifest file 'wcwidth.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'wcwidth.egg-info/SOURCES.txt'
running check
creating wcwidth-0.2.3
creating wcwidth-0.2.3/tests
creating wcwidth-0.2.3/wcwidth
creating wcwidth-0.2.3/wcwidth.egg-info
copying files to wcwidth-0.2.3...
copying LICENSE -> wcwidth-0.2.3
copying MANIFEST.in -> wcwidth-0.2.3
copying README.rst -> wcwidth-0.2.3
copying setup.cfg -> wcwidth-0.2.3
copying setup.py -> wcwidth-0.2.3
copying tests/__init__.py -> wcwidth-0.2.3/tests
copying tests/test_core.py -> wcwidth-0.2.3/tests
copying tests/test_ucslevel.py -> wcwidth-0.2.3/tests
copying wcwidth/__init__.py -> wcwidth-0.2.3/wcwidth
copying wcwidth/table_wide.py -> wcwidth-0.2.3/wcwidth
copying wcwidth/table_zero.py -> wcwidth-0.2.3/wcwidth
copying wcwidth/version.json -> wcwidth-0.2.3/wcwidth
copying wcwidth/wcwidth.py -> wcwidth-0.2.3/wcwidth
copying wcwidth.egg-info/PKG-INFO -> wcwidth-0.2.3/wcwidth.egg-info
copying wcwidth.egg-info/SOURCES.txt -> wcwidth-0.2.3/wcwidth.egg-info
copying wcwidth.egg-info/dependency_links.txt -> wcwidth-0.2.3/wcwidth.egg-info
copying wcwidth.egg-info/requires.txt -> wcwidth-0.2.3/wcwidth.egg-info
copying wcwidth.egg-info/top_level.txt -> wcwidth-0.2.3/wcwidth.egg-info
copying wcwidth.egg-info/zip-safe -> wcwidth-0.2.3/wcwidth.egg-info
Writing wcwidth-0.2.3/setup.cfg
Creating tar archive
removing 'wcwidth-0.2.3' (and everything under it)
running bdist_wheel
running build
running build_py
copying wcwidth/version.json -> build/lib/wcwidth
installing to build/bdist.macosx-10.15-x86_64/wheel
running install
running install_lib
creating build/bdist.macosx-10.15-x86_64/wheel
creating build/bdist.macosx-10.15-x86_64/wheel/wcwidth
copying build/lib/wcwidth/version.json -> build/bdist.macosx-10.15-x86_64/wheel/wcwidth
copying build/lib/wcwidth/wcwidth.py -> build/bdist.macosx-10.15-x86_64/wheel/wcwidth
copying build/lib/wcwidth/table_zero.py -> build/bdist.macosx-10.15-x86_64/wheel/wcwidth
creating build/bdist.macosx-10.15-x86_64/wheel/wcwidth/tests
copying build/lib/wcwidth/tests/test_core.py -> build/bdist.macosx-10.15-x86_64/wheel/wcwidth/tests
copying build/lib/wcwidth/tests/__init__.py -> build/bdist.macosx-10.15-x86_64/wheel/wcwidth/tests
copying build/lib/wcwidth/__init__.py -> build/bdist.macosx-10.15-x86_64/wheel/wcwidth
copying build/lib/wcwidth/table_wide.py -> build/bdist.macosx-10.15-x86_64/wheel/wcwidth
running install_egg_info
Copying wcwidth.egg-info to build/bdist.macosx-10.15-x86_64/wheel/wcwidth-0.2.3-py3.8.egg-info
running install_scripts
creating build/bdist.macosx-10.15-x86_64/wheel/wcwidth-0.2.3.dist-info/WHEEL
creating 'dist/wcwidth-0.2.3-py2.py3-none-any.whl' and adding 'build/bdist.macosx-10.15-x86_64/wheel' to it
adding 'wcwidth/__init__.py'
adding 'wcwidth/table_wide.py'
adding 'wcwidth/table_zero.py'
adding 'wcwidth/version.json'
adding 'wcwidth/wcwidth.py'
adding 'wcwidth/tests/__init__.py'
adding 'wcwidth/tests/test_core.py'
adding 'wcwidth-0.2.3.dist-info/LICENSE'
adding 'wcwidth-0.2.3.dist-info/METADATA'
adding 'wcwidth-0.2.3.dist-info/WHEEL'
adding 'wcwidth-0.2.3.dist-info/top_level.txt'
adding 'wcwidth-0.2.3.dist-info/zip-safe'
adding 'wcwidth-0.2.3.dist-info/RECORD'
removing build/bdist.macosx-10.15-x86_64/wheel

please confirm, I don't want to keep making minor releases, is this ok with you?

@jquast
Copy link
Owner

jquast commented Jun 2, 2020

tests/test_ucslevel.py is not included in bdist, but is included in sdist, for example

@avylove
Copy link
Contributor Author

avylove commented Jun 2, 2020

I think that's normal. RPMs are built from sdist.

@jquast
Copy link
Owner

jquast commented Jun 2, 2020

ok, i will publish 0.2.3 shortly, then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants