Skip to content

Add a word which has an irregular plural #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 6, 2020

Conversation

frodo821
Copy link
Contributor

@frodo821 frodo821 commented Jan 9, 2020

The word passerby has an irregular form of plural, which is formal passersby or colloquial passerby. But this library pluralizes/singularizes the word into passerbies. I fixed the bug.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Plural of the word 'passerby' is 'passersby' or 'passerbys'

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
now the word passersby matches singular regexp of passerby
Copy link

@itsumura-h itsumura-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@itsumura-h itsumura-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@jpvanhal jpvanhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jpvanhal jpvanhal merged commit 1969b3a into jpvanhal:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants