Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Ensure existing dest correct type/target in ensureLink/Symlink #826

Merged
merged 1 commit into from Apr 2, 2021

Conversation

RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented Jul 29, 2020

Fixes #786
Fixes #870

CC @CxRes

@RyanZim RyanZim added this to the 10.0.0 milestone Jul 29, 2020
lib/ensure/link.js Outdated Show resolved Hide resolved
@RyanZim RyanZim changed the title BREAKING: Error if destination wrong type for ensureLink/Symlink BREAKING: Ensure existing dest correct type/target in ensureLink/Symlink Apr 1, 2021
@RyanZim
Copy link
Collaborator Author

RyanZim commented Apr 1, 2021

@manidlou Finally got around to updating this; now checks both the type of the dest, and also ensures the dest matches the source as requested. If the dest exists, but is the wrong type, or points to the wrong place, allows it to error out.

Copy link
Collaborator

@manidlou manidlou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants