Remove unneeded and buggy stats check

[RyanZim]

As per nodejs/node#39372 (comment); haven't gotten a response from @bcoe there yet

Resolves #918

Hope this logic is right.

[RyanZim]

@manidlou @bcoe bump

[RyanZim]

I have been trying to write a test case for this; I cannot get to a place where this condition is ever reached. Do we need this at all? Or what am I missing?

[manidlou]

@RyanZim thank you for your efforts! I really appreciate it!

This is basically a wild edge case where we're trying to avoid broken copy when src is a link and its resolved path is inside the dest directory. We already have this test

node-fs-extra/lib/copy/__tests__/copy-prevent-copying-into-itself.test.js

Lines 282 to 296 in e6a9505

	it('should error when resolved src path is a subdir of dest', done => {
	const dest = path.join(TEST_DIR, 'dest')
	const resolvedSrcPath = path.join(dest, 'contains', 'src')
	const srcLink = path.join(TEST_DIR, 'src-symlink')
	fs.copySync(src, resolvedSrcPath)
	// make symlink that points to a subdir in dest
	fs.symlinkSync(resolvedSrcPath, srcLink, 'dir')
	fs.copy(srcLink, dest, err => {
	assert(err)
	done()
	})
	})

so, what's wrong with this test?

[RyanZim]

@manidlou The problem is that that test doesn't actually exercise this condition. We'd expect the error to be of the format:

Cannot overwrite '${resolvedDest}' with '${resolvedSrc}'.

Instead, if you insert a log statement in that test, the actual error thrown is:

Error: Cannot overwrite directory '/tmp/fs-extra/copy-prevent-copying-into-itself/dest' with non-directory '/tmp/fs-extra/copy-prevent-copying-into-itself/src-symlink'.

[RyanZim]

I'm going to merge this as-is, without an explicit test, as it's certainly better than what we have now. However, we should still look into properly testing this later.

[manidlou]

Thank you @RyanZim! That makes sense.