Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port copy fix from Node.js core #918

Closed
RyanZim opened this issue Aug 10, 2021 · 4 comments · Fixed by #976
Closed

Port copy fix from Node.js core #918

RyanZim opened this issue Aug 10, 2021 · 4 comments · Fixed by #976
Assignees
@manidlou @RyanZim
Labels
backport feature-copy
Milestone
11.0.0

Comments

@RyanZim
Copy link
Collaborator

RyanZim commented Aug 10, 2021

Just opening an issue for nodejs/node#39372 (comment) so this doesn't get forgotten.
@RyanZim RyanZim added this to the 11.0.0 milestone Sep 21, 2021
@RyanZim
Copy link
Collaborator Author

RyanZim commented Sep 21, 2021

@manidlou FYI, will be working on pushing a new major release in the coming days with ESM support (refs #746 (comment)); any chance you could tackle this soon?

@rxliuli
Copy link

rxliuli commented Sep 25, 2021 •
edited

It seems not difficult to support esm/cjs at the same time through the build tool, why not do this? esm only can cause other problems. For example, some packages only support cjs, and some packages only support esm. This is very annoying. I can only package all dependencies into the bundle through the build tool.

@RyanZim
Copy link
Collaborator Author

RyanZim commented Sep 25, 2021

@rxliuli We are planning to support both CJS and ESM; due to some special considerations, we can't just use an out of the box solution. See the issue for more details.

@RyanZim RyanZim mentioned this issue Oct 20, 2022
Closed
2 tasks
@RyanZim
Copy link
Collaborator Author

RyanZim commented Oct 20, 2022

There's a real bug here, but I'm not sure if @bcoe fixed it correctly; see nodejs/node#39372 (comment)

@RyanZim RyanZim self-assigned this Oct 20, 2022
RyanZim added a commit that referenced this issue Oct 25, 2022
@RyanZim
Remove unneeded and buggy stats check
fe73a03 
As per nodejs/node#39372 (comment)

Resolves #918
@RyanZim RyanZim mentioned this issue Oct 25, 2022
Merged
RyanZim added a commit that referenced this issue Nov 19, 2022
@RyanZim
Remove unneeded and buggy stats check (#976)
1a3205d 
As per nodejs/node#39372 (comment)

Resolves #918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manidlou manidlou

@RyanZim RyanZim

Labels
backport feature-copy
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

Remove unneeded and buggy stats check jprichardson/node-fs-extra
3 participants
@manidlou @RyanZim @rxliuli