Skip to content

Add docs to explain whether move supports directories as destination #830

Closed
@Pomax

Description

@Pomax

Given that mv somefile.txt textfiles will happily move a file somefile.txt into a dir textfiles, one might expect move('somefile.txt', 'textfiles') to work, but the docs currently do not explain what a valid dest is. Could the docs be amended to make it explicit whether dest must be a file path, or whether any path is valid?

Activity

RyanZim

RyanZim commented on Aug 20, 2020

@RyanZim
Collaborator

Sure, PR welcome.

Pomax

Pomax commented on Aug 22, 2020

@Pomax
Author

Just a friendly reminder that "PRs welcome" isn't really the best phrase to use. To people who file issues, it's effectively a polite way to say "if you want this, go do it yourself", and is one of those phrases that seemed like a good idea when it first popped up, but actually hurts a project more than it helps. A "Good idea!" response and then setting some labels like "docs", "enhancement", and "help wanted" to signal this probably won't get done by the core team itself unless someone has a spare moment is by far the more welcoming approach.

(I will unfortunately not be filing that PR: I'm weeks deep into a 100+ page open source project documentation rewrite already, and have enough on my plate that filing docs improvement requests is the best I can do right now)

added a commit that references this issue on Apr 15, 2021
309b1d1
added a commit that references this issue on Apr 17, 2021
ce29957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @Pomax@RyanZim

      Issue actions

        Add docs to explain whether `move` supports directories as destination · Issue #830 · jprichardson/node-fs-extra