Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Refactor the entire code base to Promise-based #1020

Closed
SukkaW opened this issue Oct 19, 2023 · 3 comments
Closed

[Proposal] Refactor the entire code base to Promise-based #1020

SukkaW opened this issue Oct 19, 2023 · 3 comments

Comments

@SukkaW
Copy link
Contributor

SukkaW commented Oct 19, 2023

We can use async and await to organize the codebase and universalify.fromPromise to create Node.js-callback style APIs from the promise-based APIs.

@RyanZim
Copy link
Collaborator

RyanZim commented Oct 19, 2023

Yeah; that'd be great. It's a ton of work, but if you want to take a stab at it, you're more than welcome to! Just please make granular PRs; not one gigantic PR that takes hours to review.

@SukkaW
Copy link
Contributor Author

SukkaW commented Oct 19, 2023

Yeah; that'd be great. It's a ton of work, but if you want to take a stab at it, you're more than welcome to! Just please make granular PRs; not one gigantic PR that takes hours to review.


Sure! Let's do one API migration per PR. And I can make each PR safe to even be included in a minor version bump (a.k.a. No breaking changes!).

I will list the roadmap here for progress tracking:

@RyanZim
Copy link
Collaborator

RyanZim commented Oct 26, 2023

Closing as this is now completed. Thanks again for all your efforts here!

@RyanZim RyanZim closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants