From 28173ed31b2a603746820e4c37a08d5363b7b2de Mon Sep 17 00:00:00 2001 From: Ryan Zimmerman <17342435+RyanZim@users.noreply.github.com> Date: Thu, 14 May 2020 10:24:23 -0400 Subject: [PATCH] Fix tests on Node 14 (#800) * Fix tests on Node 14 Fixes #798 writeFileSync requires a data parameter * Add Node 14 to CI --- .travis.yml | 1 + appveyor.yml | 2 +- lib/ensure/__tests__/create.test.js | 4 ++-- lib/remove/__tests__/remove.test.js | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index de0378f4..b2d8c293 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,6 +7,7 @@ node_js: - 11 - 12 - 13 + - 14 env: TEST_SUITE=unit matrix: exclude: diff --git a/appveyor.yml b/appveyor.yml index 32db05f9..e00f56b0 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -4,7 +4,7 @@ environment: # node.js - nodejs_version: "10" - nodejs_version: "12" - + - nodejs_version: "14" # Install scripts. (runs after repo cloning) install: # Get the latest stable version of Node.js or io.js diff --git a/lib/ensure/__tests__/create.test.js b/lib/ensure/__tests__/create.test.js index 27f8bd6f..44803326 100644 --- a/lib/ensure/__tests__/create.test.js +++ b/lib/ensure/__tests__/create.test.js @@ -46,7 +46,7 @@ describe('fs-extra', () => { it('should give clear error if node in directory tree is a file', done => { const existingFile = path.join(TEST_DIR, Math.random() + 'ts-e', Math.random() + '.txt') fse.mkdirsSync(path.dirname(existingFile)) - fs.writeFileSync(existingFile) + fs.writeFileSync(existingFile, '') const file = path.join(existingFile, Math.random() + '.txt') fse.createFile(file, err => { @@ -79,7 +79,7 @@ describe('fs-extra', () => { it('should give clear error if node in directory tree is a file', () => { const existingFile = path.join(TEST_DIR, Math.random() + 'ts-e', Math.random() + '.txt') fse.mkdirsSync(path.dirname(existingFile)) - fs.writeFileSync(existingFile) + fs.writeFileSync(existingFile, '') const file = path.join(existingFile, Math.random() + '.txt') try { diff --git a/lib/remove/__tests__/remove.test.js b/lib/remove/__tests__/remove.test.js index ff14ae69..27efe262 100644 --- a/lib/remove/__tests__/remove.test.js +++ b/lib/remove/__tests__/remove.test.js @@ -21,7 +21,7 @@ function buildFixtureDir () { const subDir = path.join(TEST_DIR, Math.random() + '') fs.mkdirSync(subDir) - fs.writeFileSync(path.join(subDir, Math.random() + '')) + fs.writeFileSync(path.join(subDir, Math.random() + ''), buf) return baseDir }