New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send path to svgo #61
Conversation
Tested with npm link and work great 👍 |
Hi Sébastien, thanks for your PR! I'll look into it next week. |
Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work. Could you review my comments?
Also, is it possible for you to add a cypress test for this change?
Actually I think path should be passed to |
Do you want me to make that change too ? See https://github.com/oliverfindl/vue-svg-inline-loader/blob/28051895a5db3c3beba6025963106566d4cee84a/src/index.js#L234 |
I added one test |
In the svgo readme, it looks like you can add config to |
Thanks for adding the test! |
@jpkleemans I fixed the merge conflicts. |
Thank you! |
Fix #60