Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ?skipsvgo url option #43

Merged
merged 2 commits into from Aug 18, 2022
Merged

adding ?skipsvgo url option #43

merged 2 commits into from Aug 18, 2022

Conversation

mdunisch
Copy link
Contributor

@mdunisch mdunisch commented Mar 9, 2022

I had a few svg icons that need other options for the optimization. So a one fits all SVGO config dont fit here.

As a quick fix i added a option to skip svgo for a specific file

@mdunisch
Copy link
Contributor Author

mdunisch commented May 2, 2022

@jpkleemans can you have a look into this PR? We really need this functionality

Copy link
Owner

@jpkleemans jpkleemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Martin, I'm sorry for the delay. Thanks for your PR!
Could you review my comments?

index.d.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mdunisch
Copy link
Contributor Author

mdunisch commented Jul 3, 2022

hey @jpkleemans your are right - i changed the return types (typescript and docs) as suggested! Could you have a 2nd look?

@jpkleemans jpkleemans merged commit 20acc72 into jpkleemans:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants