Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support decoding with external JPEG tables #85

Open
targos opened this issue Jan 23, 2021 · 1 comment
Open

Support decoding with external JPEG tables #85

targos opened this issue Jan 23, 2021 · 1 comment

Comments

@targos
Copy link

targos commented Jan 23, 2021

Hi! I'm looking into supporting the Photoshop JPEG extension in my TIFF decoder and would love to be able to use jpeg-js under the hood!
However, I am currently blocked because the TIFF JPEG compression allows to specify JPEG quantization and/or Huffman tables in a field separated from the main JPEG data. Would you be open to adding support for that in jpeg-js? I can work on it, but would like to be sure it will be accepted before I do, and maybe get some help on how to expose it in the API.

@patrickhulce
Copy link
Collaborator

Hey @targos neat project thanks for filing :)

We're pretty risk adverse at this stage in the project's life, so if you think it can be pulled off with minimal refactoring of the existing decoding path and a completely separate set of methods in the API for invoking the individual pieces you need, then I'm happy to land, but if it starts to get too murky and/or lots of state or flow changes we probably wouldn't accept it.

I think it should be doable to expose a bit of the underlying logic out into separate methods we can export. You might need to piece together the flow things yourself in tiff though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants