Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom Error subclasses instead of instancing Error directly #42

Open
Acksell opened this issue Jul 3, 2018 · 1 comment
Open

Comments

@Acksell
Copy link

Acksell commented Jul 3, 2018

It would be nice if you could identify an error by its class rather than the message that is thrown. This allows the client to more easily adhere to the principle of only catching errors that you intend to catch.

Specifically in lib/decode.js.

@patrickhulce
Copy link
Collaborator

Good idea! Wanna give this a shot? The below might be a decent start

class JPEGError extends Error {
	constructor(message) {
		super(message);
		this.name = 'JPEGError';
	}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants