Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw early on unexpected inputs #37

Open
robertmain opened this issue Jan 14, 2018 · 2 comments
Open

Throw early on unexpected inputs #37

robertmain opened this issue Jan 14, 2018 · 2 comments
Labels
enhancement good-first-issue

Comments

@robertmain
Copy link

I'm currently working on a library that depends upon this. Unless I've missed something, it doesn't seem to have any error handling? So if someone passes in an arbitrary string of text, it will quite happily try to chew through that and create a jpeg from it. I'm thinking it should maybe raise an error or something?
@patrickhulce patrickhulce changed the title Error handling Throw early on unexpected inputs Jul 28, 2018
@patrickhulce
Copy link
Collaborator

Sure PR welcome for better input detection and throwing early :)

@robertmain
Copy link
Author

Sounds good - I'll try and put something together if I have time :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good-first-issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertmain @patrickhulce