New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to verify with private key on ECAlgorithm, as well as on Ed25519Algorithm. #645

Merged

jpadilla merged 3 commits into jpadilla:master from dajiaji:fix-ec-verify

Apr 16, 2021

Contributor

dajiaji commented Apr 9, 2021

At the current implementation of Ed25519Algorithm, verify() can accept a private key as a verification key (See https://github.com/jpadilla/pyjwt/blob/master/jwt/algorithms.py#L583-L584). However, ECAlgorithm's verify() cannot.

I think the both of two should work in the same way. There are two options:

Remove private key support from Ed25519Algorithm's verify().
Add private key support to ECAlgorithm's verify().

Considering backward-compat, I selected 2.

dajiaji added 3 commits

March 19, 2021 16:34


          Add private key support for ECAlgorithm verify.

535fd85


          Merge branch 'master' into fix-ec-verify

a442b44


          Update CHANGELOG.

20904bd

jpadilla approved these changes

View reviewed changes

Owner

jpadilla left a comment

thanks!

jpadilla merged commit fb86f9d into jpadilla:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment