Simplify tox configuration #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the extra dimension: {windows,linux}. In local testing, this
suffix has no practical effect on test runs as the OS is always either
Linux or Window. Adding this suffixes forces many extra test runs when
simply using the command "tox". This has been removed to avoid these
extra runs. This allowed removing the environment variable PLATFORM.
Both Windows and Linux still run in CI.
Use only the component "crypto" to install the extra cryptography
package. This simplifies adding Python versions in the future as
modifying this line is no longer required.
Merge suffixes to one line: py{36,37,38,39}-{crypto,nocrypto}. Again,
this simplifies adding Python versions in the future as one needs to
modify only one line.
jpadilla
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the extra dimension: {windows,linux}. In local testing, this
suffix has no practical effect on test runs as the OS is always either
Linux or Window. Adding this suffixes forces many extra test runs when
simply using the command "tox". This has been removed to avoid these
extra runs. This allowed removing the environment variable PLATFORM.
Both Windows and Linux still run in CI.
Use only the component "crypto" to install the extra cryptography
package. This simplifies adding Python versions in the future as
modifying this line is no longer required.
Merge suffixes to one line: py{36,37,38,39}-{crypto,nocrypto}. Again,
this simplifies adding Python versions in the future as one needs to
modify only one line.