#26: Adding an "overwrite" flag to read_dotenv, False by default. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpadilla All tests passing. What's your release schedule look like for this? We would love to be able to use this in our project, but this issue is causing breakage in our tests—wondering if we can rely on this soon being available on PyPi or if we should make our own dependency? |
|
@alexdlaird thanks you for working on this! I'll publish a new version today. |
|
@alexdlaird done, thanks again https://github.com/jpadilla/django-dotenv/releases/tag/1.4.2 |
|
Really helpful, thanks @alexdlaird and @jpadilla! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #26.
Allows for an optional "overwrite" parameter, False by default (so nothing existing breaks). Documented as well.
This would especially be useful when running tests, so test cases can still rely on a .env file and ensure it will override pre-existing environment variables that may not be suitable to use when running tests.