Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRITON-1943 add Jenkinsfiles to Triton repositories #64

Merged
merged 2 commits into from Oct 22, 2019
Merged

Conversation

cburroughs
Copy link
Contributor

No description provided.

@trentm
Copy link
Contributor

trentm commented Oct 21, 2019

make check failure:

00:00:41.570  deps/jsstyle/jsstyle -f tools/jsstyle.conf lib/identity.js lib/formats/rfc4253.js lib/formats/pkcs1.js lib/formats/openssh-cert.js lib/formats/x509-pem.js lib/formats/dnssec.js lib/formats/auto.js lib/formats/putty.js lib/formats/pem.js lib/formats/ssh.js lib/formats/ssh-private.js lib/formats/x509.js lib/formats/pkcs8.js lib/ed-compat.js lib/utils.js lib/algs.js lib/key.js lib/private-key.js lib/certificate.js lib/errors.js lib/ssh-buffer.js lib/fingerprint.js lib/dhe.js lib/signature.js lib/index.js
00:00:41.570  Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\S{ <-- HERE / at deps/jsstyle/jsstyle line 666.
00:00:41.570  make: *** [tools/mk/Makefile.targ:183: check-jsstyle] Error 255

is that something you've seen before?

@cburroughs
Copy link
Contributor Author

is that something you've seen before?

Hundreds of times :-( Probably fixed by #65

Merge remote-tracking branch 'origin/master' into pipeline
@codecov-io
Copy link

Codecov Report

Merging #64 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   87.11%   87.14%   +0.02%     
==========================================
  Files          25       25              
  Lines        4013     4013              
==========================================
+ Hits         3496     3497       +1     
+ Misses        517      516       -1
Impacted Files Coverage Δ
lib/signature.js 88.94% <0%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97ab59...c5bb75e. Read the comment docs.

@cburroughs cburroughs merged commit cb8c666 into master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants