Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer works with next.js 11 #8

Closed
fabb opened this issue Jul 22, 2021 · 10 comments
Closed

No longer works with next.js 11 #8

fabb opened this issue Jul 22, 2021 · 10 comments

Comments

@fabb
Copy link

fabb commented Jul 22, 2021

Does not work anymore with next.js 11 because the loader is no longer called 'next-babel-loader' but '/absolute/path/to/project/node_modules/next/dist/build/babel/loader/index.js'.

I guess this is related to next.js 11 having inlined the babel loader and others: vercel/next.js#20598

@JCMais
Copy link

JCMais commented Aug 18, 2021

@fabb did you find a fix or alternative?

@fabb
Copy link
Author

fabb commented Aug 19, 2021

I removed the plugin and duplicated the babel config for every application.

@josephluck
Copy link
Owner

Hey folks. I'm no longer maintaining this plugin, but PRs are most welcome!

@fabb
Copy link
Author

fabb commented Aug 19, 2021

@josephluck what do you use yourself instead?

maybe you could add a hint to the readme that next.js 11 is no longer supported?

@josephluck
Copy link
Owner

I'm no longer actively working with NextJS.

maybe you could add a hint to the readme that next.js 11 is no longer supported?

Good shout!

@hippotastic
Copy link
Contributor

I've fixed the issue, added tests and created a PR. Hope that helps.

@josephluck
Copy link
Owner

@rutzfutz - thank you!

Published @1.0.5 https://www.npmjs.com/package/next-plugin-custom-babel-config

@JCMais
Copy link

JCMais commented Aug 25, 2021

Thanks @rutzfutz!

@hippotastic
Copy link
Contributor

Most welcome! My thanks go to @fabb for analyzing the change that caused this bug.

@hippotastic
Copy link
Contributor

By the way, @josephluck - the NPM package description for 1.0.5 still states "This plugin doesn't work with Next 11. PRs welcome!", which isn't true anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants