Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not make generic class static if it's inherited (RCS1102) #978

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Do not make generic class static if it's inherited (RCS1102) #978

merged 3 commits into from
Oct 31, 2022

Conversation

josefpihrt
Copy link
Collaborator

@josefpihrt josefpihrt commented Oct 31, 2022 •
edited

fixes #977

@josefpihrt josefpihrt self-assigned this Oct 31, 2022
@josefpihrt josefpihrt changed the title Do not make class static Do not make generic class static if it's inherited (RCS1102) Oct 31, 2022
@josefpihrt josefpihrt merged commit b11a3ed into main Oct 31, 2022
@josefpihrt josefpihrt deleted the fix/make-static branch October 31, 2022 15:20
Haarmees pushed a commit to Haarmees/Roslynator that referenced this pull request Oct 30, 2023
@josefpihrt @JochemHarmes
Do not make generic class static if it's inherited (RCS1102) (dotnet#978
144cb3c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@josefpihrt josefpihrt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RCS1102 triggers false positive when inherited by nested class
1 participant
@josefpihrt