New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determinant with small numbers fix #3139
Conversation
missing dot in `A._size`
Thanks David. You call this PR an "attempt", but it looks like it fully addresses the rounding issue for |
Hi Jos, thanks for the review! I agree I shouldn't have called it an "attempt" as it indeed solves the issue in my tests. I was hesitant that I didn't follow the suggestions exactly but I should have phrased it differently. I agree with you, I will look into I will be back during the week with that change. |
With this latest commit |
Thanks, this looks good David! |
And, reminder to myself reading #2838: we should publish this as a breaking change. |
I included the test for #3135 |
Looks good to me. It indeed feels like a quite specific test, but I think it's fine (we can always add more tests if needed in the future). I'll merge this PR now in a new |
This is an attempt to fix #3135, the issue is that isZero yields false when beeing very close to zero.
I found an issue with config.epsilon that will address separately.