Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definition missing for matrixFrom* #3115

Open
Hime-Hina opened this issue Dec 22, 2023 · 4 comments
Open

Type definition missing for matrixFrom* #3115

Hime-Hina opened this issue Dec 22, 2023 · 4 comments

Comments

@Hime-Hina
Copy link

The issues section is used only for bug reports. Please use the Discussions section to ask questions and share ideas and suggestions.

Describe the bug
The type definition of matrixFromRows is missing, also for matrixFromColumns and matrixFromFunction.

图片

To Reproduce

Create a simple typescript project.

pnpm init
pnpm add typescript -D
pnpm add mathjs
.\node_modules\.bin\tsc --init 
@josdejong
Copy link
Owner

Thanks for reporting.

Anyone able to add those functions to the type definitions? Help would be welcome!

@Hudsxn
Copy link
Contributor

Hudsxn commented Jan 31, 2024

Hi Again @josdejong, I can fill this in if you'd like?

@josdejong
Copy link
Owner

Yes please! Thanks!

Hudsxn added a commit to Hudsxn/mathjs that referenced this issue Feb 1, 2024
@Hudsxn
Copy link
Contributor

Hudsxn commented Feb 1, 2024

Hi @josdejong
Made the changes, and a couple of small improvements. :)
#3146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants