Bug in function pinv

[theoweeden]

mathjs/src/function/matrix/pinv.js

Line 120 in 49c793b

function _pinv (mat, rows, cols) {

Hiya!

I was using this in my codebase, and I found that it was the source of an issue. I ended up switching to the ml-matrix implementation of pseudoinverse, which seemed to fix my problem! I see that there's a comment suggesting this be reimplemented with SVD to improve precision - it may have been that. I can't unfortunately share the code which had the issue, but I thought I'd leave a comment all the same.

[josdejong]

Thanks for reporting Theo. Can you share a minimal example demonstrating the issue? Without that I have no clue what to look for.

[gwhitney]

@theoweeden can you at least provide a specific matrix that pinv produces incorrect results for? Presumably that wouldn't violate whatever restrictions you are under. Without some information to go on, this is not actionable and will have to be closed in a few weeks.

[theoweeden]

Hi hi, sorry for the slow response! I'll try to get a matrix example to you in the next few days - it'll take me some time to recreate the bug. Thanks for your patience.