Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes for v7 #1532

Closed
3 tasks done
josdejong opened this issue May 26, 2019 · 14 comments
Closed
3 tasks done

Breaking changes for v7 #1532

josdejong opened this issue May 26, 2019 · 14 comments

Comments

@josdejong
Copy link
Owner

josdejong commented May 26, 2019

@josdejong
Copy link
Owner Author

The issue #864 is not going to make it in v6, scheduling for v7

@harrysarson
Copy link
Collaborator

I propose removing:

// TODO: clean up some day. Deprecated since: 2018-01-24
// @deprecated upper and lower are replaced with upperExp and lowerExp since v4.0.0

mathjs/src/utils/number.js

Lines 223 to 224 in d8a4f3a

// TODO: clean up some day. Deprecated since: 2018-01-24
// @deprecated upper and lower are replaced with upperExp and lowerExp since v4.0.0

@josdejong
Copy link
Owner Author

Yes agree, and there are more deprecations I think (search code for @deprecated or cleanup).

Also good to repeat the thought I expressed in #1551 (comment):

On a side note: in some future version of mathjs (not too soon) I would like to see if we can fully move away from mathjs instances. Currently we have a complicated hybrid between pure functions and a stateful instance. Not sure if feasible and how complicated it will be, I would have to do some experimentation. The simplicity and beautiful API of UnitMath really inspires me in this regard 😄 .

@danzlarkin
Copy link

Hey @josdejong,

I really appreciate you and the others involved in maintaining this project.

Any estimated timeline relating to addressing #864 in V7?

Thanks

@josdejong
Copy link
Owner Author

Hi Daniel, thanks for your message. I myself currently don't have plans to work on it the coming period. If someone else could pick it up that would be great, but if not it will not be addressed any time soon I'm afraid.

@josdejong
Copy link
Owner Author

I've added #1761 to the breaking changes. Since I expect the other listed breaking changes not to be implemented on short term, I think we can do a breaking release soon with just this (small) change. I will wait for a couple of days to think through if there are other small things we want to have changed, and to await any feedbacks on this.

@harrysarson
Copy link
Collaborator

I added dropping node 8 support. It reached EOL at the end of December

@josdejong
Copy link
Owner Author

Thanks Harry, makes sense

@josdejong
Copy link
Owner Author

I want to release v7 within a few days, it has been a while now. There are still ongoing discussions about breaking changes but those may still take time.

So v7 will just contain the fix in #1761, drop support for node 8, and I'll add testing on nodejs 14.

@harrysarson
Copy link
Collaborator

Sounds good!

@josdejong
Copy link
Owner Author

josdejong commented May 6, 2020

I've readied the v7 release and merged it in develop, but it took longer than expected. Will do the actual release tomorrow.

EDIT: it looks like BrowserStack is slow. will look into it tomorrow.

@josdejong josdejong mentioned this issue May 7, 2020
2 tasks
@josdejong
Copy link
Owner Author

I've published v7.0.0 now.

Removing all the deprecated warnings reduced the min-zipped bundle size from 140 kB to 138 kB 😄

@harrysarson
Copy link
Collaborator

Nice job remembering to update all the browsers!

@josdejong
Copy link
Owner Author

I see I forgot to close this issue. See #1960 for details on the next breaking version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants